Bug #44

Review exception design

Added by Oliver Gierke about 2 years ago. Updated 11 months ago.

Status:In progress Start:
Priority:High Due date:
Assigned to:Marc Kannegiesser % Done:

0%
Category:core
Target version:0.4

Description

Exceptions are currently placed in a separate package. This results in all implementation packages as well as client packages being tied to this package. This strongly affects maintainability.

To gain a more functional separation over a technical one we should debate where to put the exceptions.

History

Updated by Marc Kannegiesser about 2 years ago

  • Status changed from New to In progress
currently there are four exception-classes in confyx.
in my oppinion these can be seperated in two parts: 
  • MarshalException
    as well as 
    ConfyxArchiveException
    are "framework-internal" exceptions which - in my oppinion - can stay at 
    com.synyx.confyx.exception
    • FileSystemObjectArchive
      wraps 
      MarshalException
      within 
      ConfyxArchiveException
    • StandardConfigFamily
      wraps 
      ConfyxArchiveException
      within 
      RuntimeException
  • ConfyxException
    and 
    ConfyxPolicyViolationException
    are exceptions the user might be interested in. So these should be moved to 
    com.synyx.confyx
    directly

Nevertheless I'd like to discuss exception behaviour in general (maybe ConfyxArchiveException could be a RuntimeException by itself instead of being wrapped) and so on.

Updated by Oliver Gierke 11 months ago

  • Target version changed from 0.3 to 0.4

Also available in: Atom PDF