Hades

Enhancement #162

Make derived queries work for subclasses of entity

Added by Marc Kannegiesser 9 months ago. Updated 8 months ago.

Status:

Closed

Start:

11/17/2009

Priority:

Normal

Due date:

Assigned to:

Oliver Gierke

% Done:

100%

Category:

Core DAO

Spent time:

1.00 hour

Target version:

1.1

Description

If you have an inherited structure of domain classes (e.g. a class A extends B) you usually don't need an extra GenericDao for class A since GenericDao<B> can do most of the work you need.

Right now the derived query feature (findByFoo leads to an autogenerated query like SELECT ... WHERE foo = ?) seems not to work if you query for fields that are only present in subclasses.

BDao.findByAexclusiveProperty(..) does not work since Hades inspects the domain class of the DAO (in this case B) and checks if it has the property before building the query.

Instead of inspecting B (the domain class of the dao) the return type of the method should be inspected for the property (and should be used in FROM of the query too, of course)

mylyn-context.zip (3.2 KB) Oliver Gierke, 11/17/2009 08:41 pm

Associated revisions

Revision 7963
Added by Oliver Gierke 9 months ago

fixes #162 - correct query creation for entity subclasses
added test case to recap the issue
added getReturnedDomainClass to ClassUtils to return the actual target result type (blending collections correctly)
use the new method to determine whether a field is valid
use the new method inside the domain class lookup